-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Open tab in dev mode less often #19270
Conversation
As we can not know if a tab for the application is open we add a file that is checked for modification time and after default 30 min we open a new tab on server restart. If server is restarted again before timeout file timestamp is updated. Clearing build folder will also cause new tab to open on next restart. Closes #18393
Time can be modified with the |
2bc0253
to
7ed6fb1
Compare
7ed6fb1
to
96a7ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works like a charm.
I would add the property also to VaadinConfigurationProperties
so it can be autocompleted in the IDE. Only thing I'm not completely sure if naming can clash with the existing launch-browser
property.
Added and changed to all - instead of - and . |
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.4.0. |
As we can not know if a tab
for the application is open
we add a file that is checked
for modification time and after
default 30 min we open a new tab on
server restart.
If server is restarted again before
timeout file timestamp is updated.
Clearing build folder will also
cause new tab to open on next restart.
Closes #18393