Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open tab in dev mode less often #19270

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

caalador
Copy link
Contributor

As we can not know if a tab
for the application is open
we add a file that is checked
for modification time and after
default 30 min we open a new tab on
server restart.

If server is restarted again before
timeout file timestamp is updated.

Clearing build folder will also
cause new tab to open on next restart.

Closes #18393

As we can not know if a tab
for the application is open
we add a file that is checked
for modification time and after
default 30 min we open a new tab on
server restart.

If server is restarted again before
timeout file timestamp is updated.

Clearing build folder will also
cause new tab to open on next restart.

Closes #18393
@caalador
Copy link
Contributor Author

caalador commented Apr 26, 2024

Time can be modified with the vaadin.launch-browser-delay system parameter

Copy link

github-actions bot commented Apr 26, 2024

Test Results

1 099 files  ±0  1 099 suites  ±0   1h 18m 37s ⏱️ - 1m 37s
6 997 tests ±0  6 947 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 364 runs   - 5  7 302 ✅  - 5  62 💤 ±0  0 ❌ ±0 

Results for commit b23c0b7. ± Comparison against base commit b07ac8e.

♻️ This comment has been updated with latest results.

@caalador caalador force-pushed the issues/18393-less-dev-windows branch from 2bc0253 to 7ed6fb1 Compare April 29, 2024 07:24
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Apr 29, 2024
@caalador caalador force-pushed the issues/18393-less-dev-windows branch from 7ed6fb1 to 96a7ac8 Compare April 29, 2024 07:32
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like a charm.
I would add the property also to VaadinConfigurationProperties so it can be autocompleted in the IDE. Only thing I'm not completely sure if naming can clash with the existing launch-browser property.

@caalador
Copy link
Contributor Author

Added and changed to all - instead of - and .

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mshabarov mshabarov merged commit d8fba2d into main Apr 29, 2024
26 checks passed
@mshabarov mshabarov deleted the issues/18393-less-dev-windows branch April 29, 2024 11:40
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse the existing tab in browser when Vaadin app is started in dev mode
4 participants